fix: data not returning from api-journeys to journeys modern#8944
fix: data not returning from api-journeys to journeys modern#8944
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a GraphQL field resolver Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 7c3bde6
☁️ Nx Cloud last updated this comment at |
…tomisable-text-resets-after-editing-the
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apis/api-journeys/src/app/modules/journey/journey.resolver.ts`:
- Around line 1276-1287: The resolver journeyCustomizationDescription currently
always re-fetches the Journey without filtering out soft-deleted rows and causes
unnecessary DB calls; update JourneyResolver.journeyCustomizationDescription to
first check if the parent Journey object already has
journeyCustomizationDescription (e.g., if
journey.journeyCustomizationDescription !== undefined) and return it
immediately, and only call this.prismaService.journey.findUnique when missing,
adding a soft-delete filter in the query (where: { id: journey.id, deletedAt:
null }) and selecting journeyCustomizationDescription; this avoids N+1 queries
and excludes soft-deleted journeys.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 7ac8d504-cf80-46d1-af58-e309fcc731db
📒 Files selected for processing (1)
apis/api-journeys/src/app/modules/journey/journey.resolver.ts
…tomisable-text-resets-after-editing-the
|
Plan Error |
Summary by CodeRabbit