Skip to content

chore(mobile-expo): CI lint, typecheck, and build for Expo app #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
up-tandem wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(mobile-expo): CI lint, typecheck, and build for Expo app #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
outputs:
mobile_ios: ${{ steps.affected.outputs.mobile_ios }}
mobile_android: ${{ steps.affected.outputs.mobile_android }}
mobile_expo: ${{ steps.affected.outputs.mobile_expo }}
steps:
- name: Checkout
uses: actions/checkout@v6
Expand All @@ -58,9 +59,10 @@ jobs:
run: |
BASE="${{ github.event.pull_request.base.sha || github.event.before }}"
TURBO_OUT=$(TURBO_SCM_BASE="$BASE" pnpm turbo run lint --affected --dry-run=json 2>&1) || true
AFFECTED=$(echo "$TURBO_OUT" | jq -r '[.tasks[].package] | map(select(. == "@forge/mobile-ios" or . == "@forge/mobile-android")) | .[]' 2>&1 || echo "")
AFFECTED=$(echo "$TURBO_OUT" | jq -r '[.tasks[].package] | map(select(. == "@forge/mobile-ios" or . == "@forge/mobile-android" or . == "@forge/expo")) | .[]' 2>&1 || echo "")
echo "mobile_ios=$(echo "$AFFECTED" | grep -q "@forge/mobile-ios" && echo "true" || echo "false")" >> $GITHUB_OUTPUT
echo "mobile_android=$(echo "$AFFECTED" | grep -q "@forge/mobile-android" && echo "true" || echo "false")" >> $GITHUB_OUTPUT
echo "mobile_expo=$(echo "$AFFECTED" | grep -q "@forge/expo" && echo "true" || echo "false")" >> $GITHUB_OUTPUT

generated-code:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -100,7 +102,7 @@ jobs:
- name: Check format
run: pnpm run format:check
- name: Lint JS/TS
run: pnpm turbo run lint --filter='!@forge/mobile-*' --filter='!@forge/infra' -- --max-warnings=0
run: pnpm turbo run lint --filter='!@forge/mobile-*' --filter='!@forge/expo' --filter='!@forge/infra' -- --max-warnings=0
- name: Test
run: pnpm test
- name: Build
Expand Down Expand Up @@ -141,3 +143,26 @@ jobs:
${{ runner.os }}-gradle-
- name: ktlint
run: cd mobile/android && ./gradlew ktlintCheck

lint-expo:
runs-on: ubuntu-latest
needs: affected
if: needs.affected.outputs.mobile_expo == 'true'
steps:
- name: Checkout
uses: actions/checkout@v6
- name: Setup pnpm
uses: pnpm/action-setup@v4
- name: Setup Node
uses: actions/setup-node@v6
with:
node-version-file: .nvmrc
cache: pnpm
- name: Install dependencies
run: pnpm install --frozen-lockfile
- name: Lint
run: pnpm --filter @forge/expo run lint -- --max-warnings=0
- name: Typecheck
run: pnpm --filter @forge/expo run typecheck
- name: Build
run: pnpm --filter @forge/expo run build
Loading