fix(manager): fix lint errors from coverage PR squash merge#643
Merged
fix(manager): fix lint errors from coverage PR squash merge#643
Conversation
Remove eslint-disable/enable comments referencing undefined rules (react-hooks/set-state-in-effect, @next/next/no-img-element) and fix blank lines left behind. Add CLAUDE.md rule to never skip hooks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🚅 Deployed to the forge-pr-643 environment in forge
1 service not affected by this PR
|
10b0a2f to
e35104b
Compare
e35104b to
e5da6ad
Compare
The root eslint config was missing react-hooks and @next/next plugins that CI has via eslint-config-next. This caused eslint-disable comments referencing set-state-in-effect and no-img-element to error locally as "Definition for rule not found", blocking all commits touching manager. - Add eslint-plugin-react-hooks v7 and @next/eslint-plugin-next to root - Register plugins in eslint.config.mjs for tsx/ts files - Fix prettier formatting lost during #637 squash merge - Add CLAUDE.md rule: never skip pre-commit hooks Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
e5da6ad to
769055f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
react-hooks/set-state-in-effect,@next/next/no-img-element)🤖 Generated with Claude Code