JBAI-19233 Split tracing of the LLM clients' OkHttp handlers#177
Draft
Vladislav0Art wants to merge 8 commits intomainfrom
Draft
JBAI-19233 Split tracing of the LLM clients' OkHttp handlers#177Vladislav0Art wants to merge 8 commits intomainfrom
Vladislav0Art wants to merge 8 commits intomainfrom
Conversation
Vladislav0Art
commented
Jan 26, 2026
f5cab7d to
fe77019
Compare
fe77019 to
b562fcf
Compare
Collaborator
Author
|
State: postponed for now in favor of major refactoring (PR) and further removal of dependencies on the Ktor module (PRs are tbd). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
instrument,OpenTelemetryOkHttpInterceptor,patchOpenAICompatibleClient, utilitypatchInterceptors) into a newly created moduletracing:okhttp(split these components into several files).tracing:ktorandtracing:okhttpmodules, respectively.Closes: JBAI-19233 Split tracing of the LLM clients' OkHttp handlers, similar to how Ktor is implemented?
Important Notes
Right now,
tracing:corestill has dependencies on bothKtorandOkHttplibraries! It's so because we usektor.http.ContentType, some other Ktor and OkHttp components throughout the entire modules (e..g,LangfuseExporterConfiguses Ktor's HTTP module). I tried to remove both dependencies completely, but it requires a lot of effort (e.g., we need to implement customContentType,MediaType,HttpHeaders, and more).If we plan to eradicate HTTP-specific dependencies from the
tracing:core, it should be done step-by-step and into several PRs.This PR only splits
okhttptracing-related functionalities into a separate module; nothing more.