Skip to content

refactor(github): move achievement milestones to config file #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atharv96k wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

refactor(github): move achievement milestones to config file #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
// lib/config.ts

export const CONTRIBUTION_MILESTONES = [1, 10, 100, 250, 500, 1000];
export const STREAK_MILESTONES = [3, 7, 30, 100];
3 changes: 1 addition & 2 deletions lib/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type { ContributionCalendar, ContributionDay } from '../types';
import { calculateStreak } from './calculate';
import { TTLCache } from './cache';
import { LANGUAGE_COLORS } from './svg/languageColors';
import { CONTRIBUTION_MILESTONES, STREAK_MILESTONES } from './config';

interface GitHubRepo {
stargazers_count: number;
Expand All @@ -14,8 +15,6 @@ interface GitHubRepo {
const MAX_RETRIES = 3;
// Initial delay in ms; doubles on each retry.
const BASE_DELAY_MS = 500;
const CONTRIBUTION_MILESTONES = [1, 10, 100, 250, 500, 1000];
const STREAK_MILESTONES = [3, 7, 30, 100];
const GRAPHQL_TIMEOUT_MS = 8000; // 8s for GraphQL endpoint
const REST_TIMEOUT_MS = 5000; // 5s for REST endpoints

Expand Down
Loading