Skip to content

refactor(github): extract insights generation into standalone buildIn…#766

Open
BinduShree0514 wants to merge 2 commits into
JhaSourav07:mainfrom
BinduShree0514:feat/build-insights-helper
Open

refactor(github): extract insights generation into standalone buildIn…#766
BinduShree0514 wants to merge 2 commits into
JhaSourav07:mainfrom
BinduShree0514:feat/build-insights-helper

Conversation

@BinduShree0514
Copy link
Copy Markdown

Description

Fixes #298

Extracted insight generation logic into a standalone buildInsights() helper.

Added independent tests for:

  • streak > 3 path
  • streak ≤ 3 path
  • missing language fallback

getFullDashboardData() now delegates to buildInsights().

Pillar

  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A — backend refactor only.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm test locally.
  • My commits follow Conventional Commits format.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 27, 2026

@BinduShree0514 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown

👋 Hey @BinduShree0514, welcome to CommitPulse! 🎉

Thanks for opening your first pull request — this is a big deal and we appreciate the effort!

While you wait for a review, please double-check:

  • ✅ You've read the CONTRIBUTING.md checklist
  • npm run lint, npm run format, and npm run test all pass locally
  • ✅ Your PR has a visual preview if it touches any SVG output
  • 💬 You've joined our Discord for faster PR feedback

A maintainer will review your PR shortly. Hang tight! 🚀

@github-actions github-actions Bot added the needs-rebase This PR has merge conflicts and needs a rebase. label May 27, 2026
@github-actions
Copy link
Copy Markdown

⚠️ Hey @BinduShree0514, this PR has merge conflicts with the main branch.

Please pull the latest changes and resolve the conflicts so we can review it!

git fetch origin
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease

Once resolved, the needs-rebase label will be removed automatically on the next check. 🙌

@github-actions github-actions Bot added the type:refactor Code changes that neither fix a bug nor add a feature label May 27, 2026
@github-actions github-actions Bot removed the needs-rebase This PR has merge conflicts and needs a rebase. label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:refactor Code changes that neither fix a bug nor add a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(github): extract insights generation into a standalone buildInsights() function

1 participant