Fix auto_clip_fac in case of resuming from checkpoint#15
Open
greaber wants to merge 1 commit intoJianGoForIt:masterfrom
Open
Fix auto_clip_fac in case of resuming from checkpoint#15greaber wants to merge 1 commit intoJianGoForIt:masterfrom
greaber wants to merge 1 commit intoJianGoForIt:masterfrom
Conversation
Owner
|
Hi @greaber Thanks for catching the bug and submit the PR. For this error, I think the better way to resolve is to get h_max into the states saved and loaded. Cheers, Jian |
Author
|
I see. Is there any reason h_max and h_min can't just be set to 0 in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resuming from a checkpoint,
self.iteris not zero, butself._h_maxis still undefined, so the optimizer would error. The PR checks directly ifself._h_maxis defined, which should always work.