Open
Conversation
＊ Controller の入力は Search DTO を導入して置き換えた。 StudentRepository の引数名を camelCase に修正。
…ourseId)に変更 * StudentConverter の toMap 部分にマージ関数／重複検出を追加,そのテストも追加
テストはすべて通ること再確認済み。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
実装内容
動作確認
serviceのテスト、10件テスト中、10件成功
controllerのテスト、14件テスト中、14件成功
repositoryのテスト、14件テスト中、14件成功
converterのテスト、4件テスト中、4件成功
工夫した点・学んだこと
service,controller,repositoryにそれぞれ加えて、全部の復習になりました。