Add vLLM-Omni daily review knowledge - #39
Draft
hsliuustc0106 wants to merge 2 commits into
Draft
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
hsliuustc0106
requested review from
tzhouam and
zuiho-kai
and removed request for
zuiho-kai
August 5, 2026 00:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A shadow daily review of the eight vLLM-Omni PRs merged on 2026-08-03 found durable contracts that were missing from InferMatrixCopilot knowledge. The review also showed that merged diffs alone are insufficient: critical conclusions were present only in review threads, and one merged PR targeted
minicpm-challengerather thanmain.The batch keeps only executable owner-scoped rules. It does not persist raw PR evidence, incident pages, or one-off measurements.
Impact
PR review routing can now land MiniMax H3 changes in a dedicated model owner and apply focused rules for its task matrix, numerical shape, distributed topology, loading, audio, and accuracy behavior. Shared serving, diffusion, and CI reviews gain reusable gates discovered during the same intake.
No engine, adapter, playbook, or runtime behavior changes are included.
Validation
python3 knowledge/tools/check_knowledge_tree.pypython3 knowledge/tools/check_wiki_lint.pygit diff --checkPYTHONPATH=src python3 -m pytest -q test/test_knowledge_source.py test/test_adapters.py test/test_planner_playbooks.py— 23 passedtest_subprocess_tamper_defense: state wasinterruptedinstead offailedtest_repo_neutral_core:config.pyhas three repository-specific literals against a ceiling of twoFollow-up
--stage-configs-pathflag