Conversation
8756c31 to
145e64c
Compare
ec08caf to
a109b66
Compare
a109b66 to
ec05454
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modularizes Neo4j configuration into a reusable configureNeo4j.sh script, adds a helper to switch to a high-memory profile post-setup, and improves the bash test harness to support both sourced and direct execution with better fail-fast behavior.
Changes:
- Introduce
scripts/configureNeo4j.shand auseNeo4jHighMemoryProfile.shwrapper for switching Neo4j config templates. - Refactor
setupNeo4j.shto reuse the new configuration script. - Adjust test runner/tests to support direct execution and improve fail-fast behavior; fix mktemp temp-dir naming in one test.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/useNeo4jHighMemoryProfile.sh | New helper script to apply the high-memory Neo4j config template. |
| scripts/configureNeo4j.sh | New modular Neo4j configuration logic (templating/idempotent reconfiguration). |
| scripts/setupNeo4j.sh | Reuses configureNeo4j.sh instead of embedding configuration logic. |
| scripts/runTests.sh | Runs test scripts without piping into while to support fail-fast on exit. |
| scripts/testConfigureNeo4j.sh | New integration/validation tests for configureNeo4j.sh. |
| scripts/testInstallJavaScriptDependencies.sh | Make success path return/exit correctly when sourced vs executed. |
| scripts/testFilenameReferences.sh | Make success path return/exit correctly when sourced vs executed. |
| scripts/testDownloadMavenArtifacts.sh | Fix mktemp dir naming; make success path return/exit correctly. |
| scripts/testDetectChangedFiles.sh | Make success path return/exit correctly when sourced vs executed. |
| scripts/testCloneGitRepository.sh | Make success path return/exit correctly when sourced vs executed. |
| scripts/markdown/testFormatQueryResultAsMarkdownTable.sh | Make success path return/exit correctly when sourced vs executed. |
| scripts/markdown/testEmbedMarkdownIncludes.sh | Make success path return/exit correctly when sourced vs executed. |
| scripts/configuration/template-neo4j.conf | Remove template header comment (templates now appended with a generated eye-catcher). |
| scripts/configuration/template-neo4j-v4.conf | Remove template header comment (same rationale). |
| scripts/configuration/template-neo4j-v4-low-memory.conf | Remove template header comment (same rationale). |
| scripts/configuration/template-neo4j-low-memory.conf | Remove template header comment (same rationale). |
| scripts/configuration/template-neo4j-high-memory.conf | Remove template header comment (same rationale). |
| init.sh | Adds forwarding script creation for useNeo4jHighMemoryProfile.sh. |
| README.md | Documents switching to high-memory profile after setup. |
| COMMANDS.md | Adds manual command docs for applying a different Neo4j config template and workspace hints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
7f0fdf9 to
e582aaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Feature
useNeo4jHighMemoryProfile.shyou can now switch to the new high memory profile without redoing the whole analysis. This is helpful when you reach memory limits within your first analysis attempt and want to fix that in a simple way.⚙️ Optimization
runTests.shis not affected and runs as usual.🛠 Fix