Skip to content

Modularize Neo4j configuration to support profile changes#535

Merged
JohT merged 5 commits intomainfrom
feature/modularize-neo4j-configuration-and-simplify-memory-increases
Mar 16, 2026
Merged

Modularize Neo4j configuration to support profile changes#535
JohT merged 5 commits intomainfrom
feature/modularize-neo4j-configuration-and-simplify-memory-increases

Conversation

@JohT
Copy link
Owner

@JohT JohT commented Mar 14, 2026

🚀 Feature

  • Modularize Neo4j configuration and support profile changes: With useNeo4jHighMemoryProfile.sh you can now switch to the new high memory profile without redoing the whole analysis. This is helpful when you reach memory limits within your first analysis attempt and want to fix that in a simple way.

⚙️ Optimization

🛠 Fix

@JohT JohT self-assigned this Mar 14, 2026
@JohT JohT force-pushed the feature/modularize-neo4j-configuration-and-simplify-memory-increases branch 2 times, most recently from 8756c31 to 145e64c Compare March 15, 2026 10:54
@JohT JohT force-pushed the feature/modularize-neo4j-configuration-and-simplify-memory-increases branch 3 times, most recently from ec08caf to a109b66 Compare March 16, 2026 07:57
@JohT JohT force-pushed the feature/modularize-neo4j-configuration-and-simplify-memory-increases branch from a109b66 to ec05454 Compare March 16, 2026 08:24
@JohT JohT changed the title Modularize Neo4j configuration and support profile changes Modularize Neo4j configuration to support profile changes Mar 16, 2026
@JohT JohT requested a review from Copilot March 16, 2026 08:29
@JohT JohT marked this pull request as ready for review March 16, 2026 08:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modularizes Neo4j configuration into a reusable configureNeo4j.sh script, adds a helper to switch to a high-memory profile post-setup, and improves the bash test harness to support both sourced and direct execution with better fail-fast behavior.

Changes:

  • Introduce scripts/configureNeo4j.sh and a useNeo4jHighMemoryProfile.sh wrapper for switching Neo4j config templates.
  • Refactor setupNeo4j.sh to reuse the new configuration script.
  • Adjust test runner/tests to support direct execution and improve fail-fast behavior; fix mktemp temp-dir naming in one test.

Reviewed changes

Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
scripts/useNeo4jHighMemoryProfile.sh New helper script to apply the high-memory Neo4j config template.
scripts/configureNeo4j.sh New modular Neo4j configuration logic (templating/idempotent reconfiguration).
scripts/setupNeo4j.sh Reuses configureNeo4j.sh instead of embedding configuration logic.
scripts/runTests.sh Runs test scripts without piping into while to support fail-fast on exit.
scripts/testConfigureNeo4j.sh New integration/validation tests for configureNeo4j.sh.
scripts/testInstallJavaScriptDependencies.sh Make success path return/exit correctly when sourced vs executed.
scripts/testFilenameReferences.sh Make success path return/exit correctly when sourced vs executed.
scripts/testDownloadMavenArtifacts.sh Fix mktemp dir naming; make success path return/exit correctly.
scripts/testDetectChangedFiles.sh Make success path return/exit correctly when sourced vs executed.
scripts/testCloneGitRepository.sh Make success path return/exit correctly when sourced vs executed.
scripts/markdown/testFormatQueryResultAsMarkdownTable.sh Make success path return/exit correctly when sourced vs executed.
scripts/markdown/testEmbedMarkdownIncludes.sh Make success path return/exit correctly when sourced vs executed.
scripts/configuration/template-neo4j.conf Remove template header comment (templates now appended with a generated eye-catcher).
scripts/configuration/template-neo4j-v4.conf Remove template header comment (same rationale).
scripts/configuration/template-neo4j-v4-low-memory.conf Remove template header comment (same rationale).
scripts/configuration/template-neo4j-low-memory.conf Remove template header comment (same rationale).
scripts/configuration/template-neo4j-high-memory.conf Remove template header comment (same rationale).
init.sh Adds forwarding script creation for useNeo4jHighMemoryProfile.sh.
README.md Documents switching to high-memory profile after setup.
COMMANDS.md Adds manual command docs for applying a different Neo4j config template and workspace hints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

JohT and others added 2 commits March 16, 2026 09:49
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@JohT JohT force-pushed the feature/modularize-neo4j-configuration-and-simplify-memory-increases branch from 7f0fdf9 to e582aaa Compare March 16, 2026 08:52
@JohT JohT merged commit edb66b1 into main Mar 16, 2026
10 checks passed
@JohT JohT deleted the feature/modularize-neo4j-configuration-and-simplify-memory-increases branch March 16, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants