Added some new features:#4
Open
eqhes wants to merge 1 commit into
Open
Conversation
* Shortcodes and "everything else" rendering -if wanted- using the "apply_filters" function from the WordPress API.
* New option to enable/disable "p" tags around the excerpt. "p" tags are not useful when "apply_filters" is enabled (we then get this error: <p><p>some text</p></p>), and when it doesn't, it may or may not be useful depending on the theme and the admin interests.
* Added a "p" tag with the class "jmhpew_readmore" around the "read more" link. The new class allows us to edit the link styles and I think that with the "p" tag the code is more standards compliant:
Incorrect: <p>excerpt text</p><a href="#">read more</a>
Correct: <p>excerpt text</p><p><a href="#">read more</a></p>
* Added a "span" tag with the class "jmhpew_dot_excerpt" around the " [...]" text. The new class allows us to edit the styles of that element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shortcodes and "everything else" rendering -if wanted- using the "apply_filters" function from the WordPress API.
New option to enable/disable "p" tags around the excerpt. "p" tags are not useful when "apply_filters" is enabled (we then get this error:
<p><p>some text</p></p>), and when it doesn't, it may or may not be useful depending on the theme and the admin interests.Added a "p" tag with the class "jmhpew_readmore" around the "read more" link. The new class allows us to edit the link styles and I think that with the "p" tag the code is more standards compliant:
Incorrect:
<p>excerpt text</p><a href="#">read more</a>Correct:
<p>excerpt text</p><p><a href="#">read more</a></p>Added a "span" tag with the class "jmhpew_dot_excerpt" around the " [...]" text. The new class allows us to edit the styles of that element.