feat(runner-runtime): default git identity to JorisJonkers Agent#14
Merged
Merged
Conversation
The runner entrypoint configured git user.name and user.email defaults to "agent-runner", leaving an invalid email on any commit made without GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL set. The defaults are now "JorisJonkers Agent" and "agents@jorisjonkers.dev", so runner commits carry a valid, recognizable identity out of the box. Rendered artifact and manifest checksum regenerated from the template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The runner entrypoint configured the global git
user.nameanduser.emaildefaults toagent-runnerwhenGIT_AUTHOR_NAME/GIT_AUTHOR_EMAILwere unset. That left an invalid email address (agent-runner) on any commit a runner made without those variables exported.The defaults are now
JorisJonkers Agentandagents@jorisjonkers.dev, so runner commits carry a valid, recognizable identity out of the box while still honouring theGIT_AUTHOR_NAME/GIT_AUTHOR_EMAILoverrides.Changes
templates/runner-runtime/entrypoint.sh: updated theuser.name/user.emailfallback defaults.runner-manifests/runtime/entrypoint.sh: regenerated from the template viarender-agent-kit.py --write.manifest.yaml: refreshed the pinned sha256 for the rendered entrypoint.Validation
Local suite green:
ruff check,mypy,pytest,validate_manifest.py,render-agent-kit.py --check, and--doctor.