refactor: carve TranscriptStore into lease, metadata, segment and stats stores#17
Merged
Merged
Conversation
…ts stores TranscriptStore held 39 functions behind a documented TooManyFunctions suppression. Lease, metadata, segment IO, continuation, and storage-stats stores split out over a shared context that keeps the lock namespace and atomic properties writes; the suppression is gone and the new stores are unit-tested.
2a4701d to
fd89e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7. TranscriptStore (39 functions) splits into lease, metadata, segment IO, continuation and storage-stats stores over a shared context that preserves the lock namespace and atomic properties writes byte-for-byte (verified in review, including re-entrancy). The TooManyFunctions suppression is deleted; the new stores carry unit tests.