Skip to content

Validate render-drift targets with kubeconform, not byte equality #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ExtraToast merged 2 commits into from
Jul 6, 2026
Merged

Validate render-drift targets with kubeconform, not byte equality #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18e68ae
refactor: validate render-drift targets with kubeconform, not byte eq…
ExtraToast Jul 6, 2026
cffbef5
fix: use semantic YAML comparison for render-drift, not schema valida…
ExtraToast Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions actions/deploy-config-render-drift/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,16 @@ main() {
continue
fi

if cmp -s "${rendered_path}" "${committed_path}"; then
# Functional drift check: compare canonicalised YAML so formatting, key
# order, and comments do not register as drift, but real content changes
# do. This replaces exact byte matching without losing drift detection.
if diff -q \
<(yq -P 'sort_keys(..)' "${rendered_path}") \
<(yq -P 'sort_keys(..)' "${committed_path}") >/dev/null 2>&1; then
printf 'MATCH %s=%s\n' "${adapter}" "${TARGET_PATHS[$target_index]}"
else
printf 'DIFF %s=%s\n' "${adapter}" "${TARGET_PATHS[$target_index]}"
annotation error "deploy-config-schema render ${adapter} drifted from ${TARGET_PATHS[$target_index]}"
annotation error "deploy-config-schema render ${adapter} drifted from ${TARGET_PATHS[$target_index]} (semantic YAML comparison)"
drift_found=1
fi
done
Expand Down