fix: add GHCR auth and fix idempotency check in deploy-artifact publish#47
Merged
jorisjonkers-dev-agents[bot] merged 1 commit intoJul 9, 2026
Conversation
Two issues in publish.sh: 1. No GHCR authentication before oras push / cosign sign. GITHUB_TOKEN and GITHUB_ACTOR are now passed explicitly via env to publish.sh, which logs in to ghcr.io via both oras and docker at startup. 2. The idempotency check (oras manifest fetch) matched the container image tag rather than the deploy artifact, because both share the same OCI ref (ghcr.io/<owner>/<name>:<version>). Adding --media-type to the fetch call restricts the match to deploy artifacts only, preventing false-positive idempotency hits that silently used the container image digest as the artifact digest. Also removes the syft SBOM step: SBOM is only meaningful for container images (handled in container-publish.yml), not for YAML/tar deploy artifacts.
jorisjonkers-dev-agents
Bot
added
the
type: bug
jorisjonkers-dev-agents
Bot
deleted the
fix/deploy-artifact-publish-auth-and-idempotency
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues in publish.sh:
No GHCR auth before oras push / cosign sign. GITHUB_TOKEN/GITHUB_ACTOR are now passed explicitly via env to publish.sh, which logs in to ghcr.io via both oras and docker at startup.
The idempotency check matched the container image tag rather than the deploy artifact (both share the same OCI ref). Adding
--media-typeto the oras manifest fetch restricts the match to deploy artifacts only.Also removes the syft SBOM step: SBOM is only meaningful for container images (handled in container-publish.yml), not for YAML/tar deploy artifacts.