fix: remove tag from attest subject-name#53
Merged
Conversation
actions/attest-build-provenance (v2.2.3) validates subject-name as an OCI
image name, which must NOT include a tag when push-to-registry is true.
The action uses the subject-digest to construct the fully-qualified ref and
rejects any ref that already includes a tag.
Removes ":deploy-${version}" from subject-name; the digest alone is
sufficient for attestation lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/attest-build-provenance(v2.2.3) validatessubject-nameas an OCI image namepush-to-registry: true, the action must not have a tag insubject-name— it constructs the fully-qualified ref from the subject-digest and rejects any ref that already includes a tag suffixInvalid image name: ghcr.io/jorisjonkers-dev/agents-ui:deploy-v0.18.13:deploy-${version}fromsubject-name; thesubject-digestis sufficientTest plan