fix(deploy-artifact): handle npm audit no-deps skip for GHPR scoped packages#57
Merged
Merged
Conversation
jorisjonkers-dev-agents
Bot
added
area: deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy-artifact run.sh runs
npm audit signatures --scope @jorisjonkers-dev. When the installed package is from a private registry (GHPR) and the scope filter matches zero packages in the audit index, npm emits:The existing code only handled:
Both messages are expected skip conditions for GHPR-installed packages. This extends the grep to handle both messages, preventing a false E_NPM_AUDIT_SIGNATURES_FAILED failure for services that have no npm packages of their own (e.g. Kotlin services).