Skip to content

GOG: Fix automatic install process no longer working#425

Merged
JosefNemec merged 3 commits intoJosefNemec:masterfrom
darklinkpower:gogFixAutoInstall
Jun 13, 2025
Merged

GOG: Fix automatic install process no longer working#425
JosefNemec merged 3 commits intoJosefNemec:masterfrom
darklinkpower:gogFixAutoInstall

Conversation

@darklinkpower
Copy link
Copy Markdown
Contributor

  • Fixed: automatic installation option no longer working. Something changed in the client that made it stop working.
  • Changed: If the automatic install is initiated, now the game page will open to see the download progress. This way there's a visual indication that the download started, and the Galaxy window was being opened anyway so why not show something useful.

Notes regarding the install procedure:

  • If the GOG Galaxy client is started in the procedure it takes 1~ second for GalaxyClient Helper to be available to use the command.
  • Similarly, it takes around 3~4 seconds in my system for GOG Galaxy Notifications Renderer to be available after that. When it is available, the GOG splashscreen is still being displayed but it works with no issues. It's pretty invisible to the user.
  • Of course no wait is done if GOG is already running.

image

@JosefNemec
Copy link
Copy Markdown
Owner

I really do not like these time sensitive fixes, they tend to break very easily depending on performance of user's system. Not sure if it's worth keeping this feature around if we need to use these workarounds.

@darklinkpower
Copy link
Copy Markdown
Contributor Author

I agree on that. I've investigated further and found that Galaxy writes lock files when it's initialized and ready, so instead I implemented an approach of detecting these files the same way as #413.

I just kept a small delay here. There may be similar event-based way to do it but in my opinion that would add complexity unnecessarily, but let me know if it's needed.

image

Additionally, I refactored the procedure to initiate the install to the InitiateInstall method to reduce excessive nesting, I hope if's okay.

@JosefNemec
Copy link
Copy Markdown
Owner

I'll merge it, but it's likely that I will remove this option completely in P11 plugin rewrite if it no longer work in Galaxy without this workaround.

@JosefNemec JosefNemec merged commit f47f892 into JosefNemec:master Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants