Fix cask DSL deprecation and document brew trust - #57
Conversation
Homebrew 6 warns that 'depends_on macos: ">= :big_sur"' is deprecated and prints a report-this-issue notice on every tap; the symbol form already means 'at least'. Confirmed with 'brew info --cask', which now reports 'macOS >= 11' cleanly. Homebrew 6 also refuses to load casks from an untrusted third-party tap, so the documented install needs a 'brew trust' step or it fails outright.
|
Warning Review limit reached
Next review available in: 25 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The install section opened with a Linux-only release archive and buried macOS under a build-from-source heading, which no longer matches reality now that a cask exists. Add a platform table up front, put the Homebrew path first with its trust step, opening a comic, and upgrade/uninstall verbs, and fold the duplicate Homebrew section that had accumulated below it.
A cask install moved the app and cleared quarantine, but never registered with Launch Services, never set the default handlers, and never refreshed Finder's icon cache. Local testing hid this: earlier 'make install' runs had already set those, so only a new user would have found .cbz not opening on double-click. The cask now depends on duti and repeats the installer's registration, handler assignment, and icon-cache refresh. Every step is must_succeed: false, since none of them should fail an otherwise good install.
1 participant
Two issues found by actually tapping and loading the published cask, rather than assuming it was fine.
depends_on macos: ">= :big_sur"is deprecated. Homebrew 6 prints a deprecation warning plus a "report this issue to the tap" notice on everybrew tap. The symbol formdepends_on macos: :big_suralready carries the minimum-version meaning;brew info --caskconfirms it resolves to "macOS >= 11".Homebrew 6 requires explicit trust for third-party casks.
brew info --cask cdisplayagainfailed with "Refusing to load cask ... from untrusted tap". The documented install sequence needsbrew trust joshclwren/tap(orbrew trust --cask joshclwren/tap/cdisplayagain) or it does not work at all.The tap already carries the corrected cask; this fixes the generator so it cannot reintroduce the deprecated form, and documents the trust step.