Skip to content

Fix consecutive blank lines in PhoneBillXmlHelperTest.java#524

Merged
DavidWhitlock merged 3 commits intoWinter2026-SNAPSHOTfrom
copilot/sub-pr-523
Nov 28, 2025
Merged

Fix consecutive blank lines in PhoneBillXmlHelperTest.java#524
DavidWhitlock merged 3 commits intoWinter2026-SNAPSHOTfrom
copilot/sub-pr-523

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Nov 28, 2025

Addresses formatting feedback from #523 regarding inconsistent blank line usage.

  • Removed duplicate blank lines after helper instantiation in both canParseValidXmlFile() and cantParseInvalidXmlFile() test methods

Before:

PhoneBillXmlHelper helper = new PhoneBillXmlHelper();


DocumentBuilderFactory factory =

After:

PhoneBillXmlHelper helper = new PhoneBillXmlHelper();

DocumentBuilderFactory factory =

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: DavidWhitlock <2935912+DavidWhitlock@users.noreply.github.com>
Copilot AI changed the title [WIP] Update XML parsing example in Phone Bill archetype PR Fix consecutive blank lines in PhoneBillXmlHelperTest.java Nov 28, 2025
Copilot AI requested a review from DavidWhitlock November 28, 2025 13:48
Base automatically changed from phone-bill-xml-example-in-archetype to Winter2026-SNAPSHOT November 28, 2025 13:56
Copy link
Copy Markdown
Collaborator

@DavidWhitlock DavidWhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was an easy one.

@DavidWhitlock
Copy link
Copy Markdown
Collaborator

@copilot, as far as I'm concerned, this PR is ready to merge. Feel free to mark it as "ready for review".

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Nov 28, 2025

@copilot, as far as I'm concerned, this PR is ready to merge. Feel free to mark it as "ready for review".

I'm unable to mark the PR as ready for review due to environment limitations - I don't have access to the GitHub CLI with the required permissions. Could you please mark it as ready for review?

Copilot AI requested a review from DavidWhitlock November 28, 2025 14:01
@DavidWhitlock DavidWhitlock marked this pull request as ready for review November 28, 2025 14:29
Copy link
Copy Markdown
Collaborator

@DavidWhitlock DavidWhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good.

@DavidWhitlock DavidWhitlock merged commit de942a1 into Winter2026-SNAPSHOT Nov 28, 2025
3 checks passed
@DavidWhitlock DavidWhitlock deleted the copilot/sub-pr-523 branch November 28, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants