Conversation
Bro , Now check it, is it fine? Will definitely enhance the css but main thing is code, I tried so hard , You assigned me so literally I dont wanted to let u down, Plz inform me the errors in this. JsrEntity#20
|
Bro can u add hactobefest in your label topic? |
|
See @jay-deep This PR is quite good, Here are few things i would suggest..
|
|
I added these tags for now but you have to complete this, or else I am forced to close this. Thank you :) |
|
Bro actually , right now I don't know how to use bootstrap Linked new sophomore.css added navbar code from index.html Removed some br and bro I pushed it to my fork |
|
That's great, so do you want to enhance it's CSS or should I take it from here. Work both ways |
|
yeah definitely bro, it was never about hacktober fest, its just as like till 1st october , I didnt even knew how to use github, now atleast I am happy that I know a little bit. Bro Do 1 thing na, You Merge this in master and if I got something to enhance in it, I will do it parallely? What say? |
This will mess the commit logs , multiple commits for same work is not appreciated. However if you want I can merge this is new branch and when done , will merge this in master will a single commit(Squashing) . |
|
Yup that's also great |
|
I checked once merged , i guess you can't edit the commits . Then you have to send multiple PRs that's not cool. If a PR is not merged and you add new commit it will automatically show. Better to not merge it now. |
|
But now, how will u add this sophomore page in master branch? |
I will wait till you complete this task ;) |
|
Now I just need to enhance it na, I mean no need to add something na??? |
Yes enhance the styles |
Did some enhancement in css
|
okay cool, bro Did u checked the enhancements? |

Bro , Now check it, is it fine?
Will definitely enhance the css but main thing is code, I tried so hard , You assigned me so literally I dont wanted to let u down, Plz inform me the errors in this.
Fixes #3