Skip to content

Add test for extra ignore patterns#3

Open
sathvika234567 wants to merge 1 commit into
Juanmidev1:mainfrom
sathvika234567:add-extra-ignore-patterns-test
Open

Add test for extra ignore patterns#3
sathvika234567 wants to merge 1 commit into
Juanmidev1:mainfrom
sathvika234567:add-extra-ignore-patterns-test

Conversation

@sathvika234567

@sathvika234567 sathvika234567 commented Jun 21, 2026

Copy link
Copy Markdown

Summary

Checklist

  • Tests added or updated for every new or fixed behaviour
  • npm test passes locally
  • npm run typecheck and npm run lint pass without errors
  • README updated if this change affects a documented tool, parameter, or default
  • No performance budget regressions (tests/performance/ budgets still pass)

Notes for reviewer

@Juanmidev1

Copy link
Copy Markdown
Owner

Thanks for the PR — nice work with the mkdtempSync isolation and the
finally cleanup block, and good to see CI passing on all Node versions.

One thing missing before this is complete: the issue asked to verify
extraIgnorePatterns across all three tools (get_project_tree,
search_codebase, and get_project_index), and this PR only covers
get_project_tree. Could you add the same check for the other two
handlers? You should be able to reuse the same tmpRoot fixture for all
three assertions.

@sathvika234567

Copy link
Copy Markdown
Author

Thanks for the review! I'll add equivalent integration tests for search_codebase and get_project_index and update the PR.

@Juanmidev1 Juanmidev1 linked an issue Jun 21, 2026 that may be closed by this pull request
@Juanmidev1

Copy link
Copy Markdown
Owner

Hi Sathvika! Just checking in — no rush at all, but wanted to see if
you're still planning to add the search_codebase and get_project_index
tests we discussed. Let me know if you need any help or if you'd
prefer I pick it up from here.

@sathvika234567

Copy link
Copy Markdown
Author

Hi! Thanks for checking in. Sorry for the delay—I got a bit busy this week. I'm still planning to add the search_codebase and get_project_index integration tests and will work on them soon. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add integration test for extraIgnorePatterns in synapse.config.json

2 participants