Removed unneeded permissions and disabled the ogra option#44
Open
bhdouglass wants to merge 1 commit into
Open
Conversation
Collaborator
|
If I remember correctly, the files needed to build the .click are written from the stdout. |
Contributor
Author
|
@cibersheep but I only removed the UI element to select it, so I wouldn't think that would be a problem. Also I tried with and without my changes both times lead to the same crash. |
Collaborator
|
Oh, I see. Sorry. |
Contributor
Author
|
Maybe? Hopefully @Jujuyeh has some better insight here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the unnecessary permissions, disabled the ogra option (since Oxide isn't available on pinephone and is depricated), updated the clickabe.json to use the latest syntax, and removed reference to the OpenStore in the description field.
I ran into an error when testing this:
*** buffer overflow detected ***: /usr/lib/qt5/bin/qmlscene terminatedwith and without my changes, so I'm not sure what was up with that as the app from the OpenStore works fine.