Add BlockedUnitRangeFirsts/Lasts to avoid allocating#509
Open
dlfivefifty wants to merge 9 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 94.39% 92.78% -1.62%
==========================================
Files 19 20 +1
Lines 1821 1871 +50
==========================================
+ Hits 1719 1736 +17
- Misses 102 135 +33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@mtfishman it will be a while before the coverage is up and all the tests are passing. But perhaps you can have a preliminary look at this? This is fixing two previous issues:
Any general thoughts about the design would be useful. I'm not convinced with my current naming scheme. And note that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a special type to avoid allocations in
blockfirsts/blocklengths. It also removes a hack for rangedblocklaststhat didn't work when the first index wasn't consistent by introducing a special range typeFirstStepRangeLenwhen the first index matches the step.