Allow DualVector(::DualVector) for 2nd Order Methods#21
Open
max-vassili3v wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
- Coverage 70.87% 69.74% -1.13%
==========================================
Files 5 5
Lines 103 119 +16
==========================================
+ Hits 73 83 +10
- Misses 30 36 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dlfivefifty
requested changes
Feb 6, 2026
| Constructs a DualVector, ensuring that the vector length matches the number of rows in the Jacobian. | ||
| """ | ||
| struct DualVector{T, V <: AbstractVector{T},M <: AbstractMatrix{T}} <: AbstractVector{Dual{T}} | ||
| struct DualVector{T, V <: AbstractVector{<:Union{T, Dual{T}}},M <: AbstractMatrix{T}} <: AbstractVector{Dual{T}} |
Member
There was a problem hiding this comment.
Looks wrong. I don't see the role of the Union, and if the elments of value are of type Dual{T} then shouldn't the elements of jacobian also be of type Dual{T}?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes changes to type definitions to allow 'DualVectors inside DualVectors' (and similarly Dual inside Dual), paving the way for implementations of 2nd order methods. Changes are covered with unit tests