Make show round-trippable for IdOffsetRange#208
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 98.31% 98.33% +0.02%
==========================================
Files 5 5
Lines 297 301 +4
==========================================
+ Hits 292 296 +4
Misses 5 5
Continue to review full report at Codecov.
|
Member
|
I like this. Perhaps we should use 'indices' instead of 'indexes' to be consistent with the array summary convention? |
Member
Author
|
There are some fixes that should probably go into 1.6.x, but once we start thinking about a 1.7 (or 2.0) release I would plan to merge this. |
Member
Author
|
Have all bugfix PRs been merged? If so let's start on the next minor release. |
Member
|
Yes the other PRs are for the 1.7 series |
3524455 to
c381843
Compare
Member
Author
|
Looking forward to easier debugging already... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This displays both the values and indexes of an IdOffsetRange:
It also adds a constructor so that this is round-trippable:
Closes #179
Closes #193