Skip to content

Add Iqbal, Michalsky and SG2 positioning algorithms#95

Open
langestefan wants to merge 1 commit into
mainfrom
feature/iqbal-michalsky-sg2
Open

Add Iqbal, Michalsky and SG2 positioning algorithms#95
langestefan wants to merge 1 commit into
mainfrom
feature/iqbal-michalsky-sg2

Conversation

@langestefan
Copy link
Copy Markdown
Member

Implement three additional solar position algorithms:

  • Iqbal: Fourier-series declination and equation of time (no refraction).
  • Michalsky: Astronomical Almanac approximate algorithm, with options for the Spencer (1989) azimuth correction and the Julian date formulation; defaults to the MICHALSKY refraction model.
  • SG2: fast multi-decadal algorithm valid for 1980-2030 (throws outside that range); defaults to the SG2 refraction model.

Implement three additional solar position algorithms:

- Iqbal: Fourier-series declination and equation of time (no refraction).
- Michalsky: Astronomical Almanac approximate algorithm, with options for
  the Spencer (1989) azimuth correction and the Julian date formulation;
  defaults to the MICHALSKY refraction model.
- SG2: fast multi-decadal algorithm valid for 1980-2030 (throws outside
  that range); defaults to the SG2 refraction model.

To free the SG2 name for the positioning algorithm, the SG2 refraction
model is renamed SG2 -> SG2Refraction, mirroring the existing SPA /
SPARefraction split.

Enables the previously skipped iqbal/michalsky/sg2 test stubs and updates
the package and documentation tables, references and bibliography.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

❌ Patch coverage is 94.33962% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.22%. Comparing base (701f158) to head (6593509).

Files with missing lines Patch % Lines
src/Positioning/sg2.jl 94.00% 3 Missing ⚠️
src/Positioning/michalsky.jl 94.87% 2 Missing ⚠️
src/Positioning/iqbal.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #95      +/-   ##
===========================================
- Coverage   100.00%   99.22%   -0.78%     
===========================================
  Files           17       20       +3     
  Lines          666      771     +105     
===========================================
+ Hits           666      765      +99     
- Misses           0        6       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant