get rid of type piracy and update the minimum julia version#59
Open
KristofferC wants to merge 1 commit into
Open
get rid of type piracy and update the minimum julia version#59KristofferC wants to merge 1 commit into
KristofferC wants to merge 1 commit into
Conversation
KristofferC
force-pushed
the
kc/type_piracy_julia_min
branch
from
f511cde to
9f3999e
Compare
devmotion
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hasmethod(Base.haskey, (Any, Any))check isfalseon julia after JuliaLang/julia#43880 (since 1.10), so this method gets defined, which causes type piracy and invalidations. I think at this point we can just update the minimum version and get rid of some cruft by doing so.