Address #134 by allowing images to be added to sheets#391
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 94.62% 95.12% +0.49%
==========================================
Files 21 22 +1
Lines 7056 7509 +453
==========================================
+ Hits 6677 7143 +466
+ Misses 379 366 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshday
added a commit
to joshday/XLSX.jl
that referenced
this pull request
May 19, 2026
Sync the WIP XML.jl v0.4 branch with 46 commits of upstream progress (v0.11.4 through v0.11.8): image support (JuliaData#391/JuliaData#134), .xltx templates (JuliaData#293), Issue JuliaData#368/JuliaData#380 fixes, custom missing strings (JuliaData#90/JuliaData#363), iserror/geterror, passive chartsheet support, Dependabot, relocatable data, and the expanded test suite. All 60 conflict hunks across 12 src files resolved by keeping the XML.jl v0.4 API surface and porting upstream feature/bugfix logic. Package precompiles; 1893 tests pass. Known WIP gaps (NOT merge regressions): the newly merged upstream "no default namespace" testset (issues JuliaData#380/JuliaData#362/JuliaData#267/JuliaData#170) has 3 failures + 1 error. The v0.4 read path does not yet handle no-default-namespace files (string cells read empty) or upstream's new conditional ext formats. Verified upstream master handles these correctly and normal-namespace string reading still works here, so these are pre-existing v0.4 implementation gaps to be addressed as part of the v0.4 port, not caused by this merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.