Defer field lookup in @adapt_structure to fix nested-macro use.#107
Merged
Conversation
The macro previously called `Core.eval(__module__, T)` at expansion time, which fails when @adapt_structure is invoked inside another macro that wraps its body in a function (e.g. @testset), because the struct definition has not run yet at macroexpand time. Switch to a @generated function so field names are queried at codegen time, when the type is guaranteed to exist. The emitted IR is identical to the original (direct getfield + %new), so there is no performance regression. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The macro previously called
Core.eval(__module__, T)at expansion time, which fails when @adapt_structure is invoked inside another macro that wraps its body in a function (e.g. @testset), because the struct definition has not run yet at macroexpand time. Switch to a @generated function so field names are queried at codegen time, when the type is guaranteed to exist. The emitted IR is identical to the original (direct getfield + %new), so there is no performance regression.Fixes #102