Skip to content

Preserve uplo when adapting Symmetric/Hermitian wrappers. #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maleadt merged 1 commit into from
Jun 10, 2026
Merged

Preserve uplo when adapting Symmetric/Hermitian wrappers. #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "Adapt"
uuid = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
version = "4.6.0"
version = "4.6.1"

[workspace]
projects = ["test"]
Expand Down
4 changes: 2 additions & 2 deletions src/wrappers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ adapt_structure(to, A::LinearAlgebra.Tridiagonal) =
adapt_structure(to, A::LinearAlgebra.Bidiagonal) =
LinearAlgebra.Bidiagonal(adapt(to, A.dv), adapt(to, A.ev), A.uplo)
adapt_structure(to, A::LinearAlgebra.Symmetric) =
LinearAlgebra.Symmetric(adapt(to, parent(A)))
LinearAlgebra.Symmetric(adapt(to, parent(A)), A.uplo == 'U' ? :U : :L)
adapt_structure(to, A::LinearAlgebra.Hermitian) =
LinearAlgebra.Hermitian(adapt(to, parent(A)))
LinearAlgebra.Hermitian(adapt(to, parent(A)), A.uplo == 'U' ? :U : :L)


# we generally don't support multiple layers of wrappers, but some occur often
Expand Down
2 changes: 2 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ using LinearAlgebra
@test_adapt CustomArray UnitUpperTriangular(mat.arr) UnitUpperTriangular(mat) AnyCustomArray
@test_adapt CustomArray Symmetric(mat.arr) Symmetric(mat) AnyCustomArray
@test_adapt CustomArray Hermitian(mat.arr) Hermitian(mat) AnyCustomArray
@test_adapt CustomArray Symmetric(mat.arr, :L) Symmetric(mat, :L) AnyCustomArray
@test_adapt CustomArray Hermitian(mat.arr, :L) Hermitian(mat, :L) AnyCustomArray

@test_adapt CustomArray Diagonal(vec.arr) Diagonal(vec) AnyCustomArray

Expand Down
Loading