Skip to content

Temporarily work around 1.12 failures #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christiangnrd merged 4 commits into from
Feb 6, 2026
+17 −11
Merged

Temporarily work around 1.12 failures #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d74ff82
Fix typo in exception reporting
christiangnrd Jan 16, 2026
8728bf6
Disable error reporting for 1.12
christiangnrd Jan 16, 2026
7fbfe83
Test 1.12
christiangnrd Jan 16, 2026
22e50ac
Format
christiangnrd Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ['1.10', '1.11']
version: ['1.10', '1.11', '1.12']
os: [ubuntu-24.04, ubuntu-24.04-arm, macOS-15, macOS-15-intel, windows-2022]
arch: [x64, arm64]
pocl: [jll, local]
Expand Down
26 changes: 16 additions & 10 deletions src/pocl/device/runtime.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,29 @@ report_oom(sz) = return
import SPIRVIntrinsics: get_global_id

function report_exception(ex)
SPIRVIntrinsics.@printf(
"ERROR: a %s was thrown during kernel execution on thread (%d, %d, %d).\n",
ex, get_global_id(UInt32(0)), get_global_id(UInt32(1)), get_global_id(UInt32(2))
)
@static if VERSION < v"1.12"
SPIRVIntrinsics.@printf(
"ERROR: a %s was thrown during kernel execution on thread (%d, %d, %d).\n",
ex, get_global_id(UInt32(1)), get_global_id(UInt32(2)), get_global_id(UInt32(3))
)
end
return
end

function report_exception_name(ex)
SPIRVIntrinsics.@printf(
"ERROR: a %s was thrown during kernel execution on thread (%d, %d, %d).\n",
ex, get_global_id(UInt32(0)), get_global_id(UInt32(1)), get_global_id(UInt32(2))
)
SPIRVIntrinsics.@printf("Stacktrace:\n")
@static if VERSION < v"1.12"
SPIRVIntrinsics.@printf(
"ERROR: a %s was thrown during kernel execution on thread (%d, %d, %d).\n",
ex, get_global_id(UInt32(1)), get_global_id(UInt32(2)), get_global_id(UInt32(3))
)
SPIRVIntrinsics.@printf("Stacktrace:\n")
end
return
end

function report_exception_frame(idx, func, file, line)
SPIRVIntrinsics.@printf(" [%d] %s at %s:%d\n", idx, func, file, line)
@static if VERSION < v"1.12"
SPIRVIntrinsics.@printf(" [%d] %s at %s:%d\n", idx, func, file, line)
end
return
end
Loading