Fix broken links to images#22
Open
alex-s-gardner wants to merge 1 commit into
Open
Conversation
Member
|
Hmm when I go to your repo/branch, those images don't come up, still looks broken for me. |
asinghvi17
reviewed
Sep 26, 2025
|
|
||
| # url to example raster file | ||
| path2raster = "https://github.com/rasterio/rasterio/raw/9953b28225db3b01193c94b1442d34b828d374aa/tests/data/RGB2.byte.tif" | ||
| path2raster = "https://github.com/JuliaGeo/Geo.jl/issues/20#issuecomment-3300557361" |
Member
There was a problem hiding this comment.
This links to an issue comment, it should rather link to the URL of the image I think?
Or we can have a JuliaGeoWebAssets repo that hosts all of this stuff, then just use raw.githubusercontent.com links.
| heatmap(ras) | ||
| ``` | ||
|  | ||
|  |
Member
There was a problem hiding this comment.
This link 404s when I click on it
| plot(gdf.geometry) | ||
| ``` | ||
|  | ||
|  |
Contributor
Author
Member
|
An assets folder would definitely bloat the repo. But a separate repo is very doable |
Contributor
Author
|
Is there a way to automate this, such that the images are generated on the fly? I would be useful as a sanity check that it's behaving as advertised. I did some googling but didn't readily find anything. If not I can create a JuliaGeoAssets repot. I think it's important for users to see visualizations up front. |
Member
|
Hmm could get images from the doc build if we save to public/ too. It's a bit hacky but not bad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix broken links to images in ReadMe that are hosted in a closed issue.