Fix PtrString hash compatibility#468
Merged
Merged
Conversation
Ensure PtrString equality with AbstractString is symmetric and hash-compatible so transient lazy keys behave correctly in hashed collections. Fixes #467
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 90.32% 90.41% +0.09%
==========================================
Files 7 7
Lines 1416 1419 +3
==========================================
+ Hits 1279 1283 +4
+ Misses 137 136 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractString/PtrStringequality so comparisons are symmetric.Base.hash(::PtrString, ::UInt)so equalPtrStringandStringvalues hash identically.Dict, andSetlookup.Root Cause
PtrStringdefined==/isequalagainstAbstractStringbut did not define a matchinghashmethod. Hash-table lookup also exposed that the equality methods only handledPtrStringon the left-hand side.Validation
tmpenv=$(mktemp -d); julia --startup-file=no --project="$tmpenv" -e 'using Pkg; Pkg.develop(path=pwd()); using JSON, Test; include("test/lazy.jl")'tmpenv=$(mktemp -d); julia --startup-file=no --project="$tmpenv" -e 'using Pkg; Pkg.develop(path=pwd()); Pkg.test("JSON")'Fixes #467
Co-authored by Codex