Skip to content

Added stdfinite, a standard deviation equivilant to meanfinite#980

Closed
jagoosw wants to merge 1 commit into
JuliaImages:masterfrom
jagoosw:add-stdfinite
Closed

Added stdfinite, a standard deviation equivilant to meanfinite#980
jagoosw wants to merge 1 commit into
JuliaImages:masterfrom
jagoosw:add-stdfinite

Conversation

@jagoosw
Copy link
Copy Markdown

@jagoosw jagoosw commented Sep 14, 2021

I can't seem to find anything that has similar functionality to meanfinite but for standard deviations and so have written up what I've been using here. It calculated the standard deviation of values in an array along given dimensions and ignores any NaN values.

I have included some basic tests and it is passing the others.

Thanks!

I can't seem to find anything that has similar functionality
to meanfinite but for standard deviations and so have written
up what I've been using here.

stdfinite calculated the standard deviation of values in an
array along given dimensions and ignores any NaN values.
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 14, 2021

Codecov Report

Merging #980 (a63947c) into master (f50f59b) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #980      +/-   ##
==========================================
+ Coverage   86.55%   86.82%   +0.26%     
==========================================
  Files           9        9              
  Lines        1086     1108      +22     
==========================================
+ Hits          940      962      +22     
  Misses        146      146              
Impacted Files Coverage Δ
src/Images.jl 0.00% <ø> (ø)
src/algorithms.jl 86.69% <100.00%> (+0.32%) ⬆️
src/deprecations.jl 87.85% <0.00%> (+0.13%) ⬆️
src/corner.jl 88.40% <0.00%> (+0.34%) ⬆️
src/edge.jl 84.51% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50f59b...a63947c. Read the comment docs.

@timholy
Copy link
Copy Markdown
Member

timholy commented Sep 14, 2021

Make sense!

These functions are moving to ImageBase, see JuliaImages/ImageBase.jl#13. Could I ask you to reopen this there? Also, can we consider:

  • making this varfinite (users can take the sqrt themselves)
  • imitating the implementation of the other functions? I think the new implementations are both more flexible and more efficient (although checking that would be useful...)

@jagoosw
Copy link
Copy Markdown
Author

jagoosw commented Sep 14, 2021

Absolutely, sorry I didn't check that issue when I was looking for where to put it.

I'll change over to that imitate the new implementations then reopen over there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants