Skip to content

Display backtrace from unexpected errors in terminate_all_workers() #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesWrigley merged 1 commit into from
Apr 14, 2026
Merged

Display backtrace from unexpected errors in terminate_all_workers() #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/cluster.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1275,7 +1275,12 @@ function terminate_all_workers()
try
rmprocs(workers(); waitfor=5.0)
catch _ex
@warn "Forcibly interrupting busy workers" exception=_ex
if _ex isa ErrorException
@warn "Forcibly interrupting busy workers" exception=_ex
Copy link
Copy Markdown
Member

@vchuravy vchuravy Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we show the backtrace in all cases?

Copy link
Copy Markdown
Member Author

@JamesWrigley JamesWrigley Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but I'd lean against it because rmprocs() timing out is semi-expected and I don't think we want to display a full stacktrace for it.

else
@error "Unexpected error when interrupting busy workers" exception=(_ex, catch_backtrace())
end

# Might be computation bound, interrupt them and try again
interrupt(workers())
try
Expand Down
Loading