staticdata: restore extext_methods and new_ext_cis to inspector svec#61868
Open
IanButterworth wants to merge 1 commit into
Open
staticdata: restore extext_methods and new_ext_cis to inspector svec#61868IanButterworth wants to merge 1 commit into
IanButterworth wants to merge 1 commit into
Conversation
`jl_restore_package_image_from_stream` (with `completeinfo=true`) loads `extext_methods` (the worklist-owned `TypeMapEntry` extensions of external functions) and `new_ext_cis` (new external `CodeInstance` specializations), GC-roots them, and feeds them to internal callers, but the final 5-element svec returned at the end of the function discards both arrays. External inspectors (e.g. PkgCacheInspector.jl) therefore have no way to enumerate either: the `internal_methods` array exposed in the svec is populated only as a side-effect of the fixup walk and on every package image examined contained zero `TypeMapEntry` objects. Return both arrays alongside `internal_methods` in a 7-element svec so the information is once again accessible. Co-authored-by: GitHub Copilot (Claude Opus 4.7) <noreply@github.com> Written with the assistance of generative AI (GitHub Copilot, Claude Opus 4.7).
IanButterworth
added
the
backport 1.13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found working on timholy/PkgCacheInspector.jl#37
Claude:
jl_restore_package_image_from_stream(withcompleteinfo=true) loadsextext_methods(the worklist-ownedTypeMapEntryextensions of external functions) andnew_ext_cis(new externalCodeInstancespecializations), GC-roots them, and feeds them to internal callers, but the final 5-element svec returned at the end of the function discards both arrays. External inspectors (e.g.PkgCacheInspector.jl) therefore have no way to enumerate either: the
internal_methodsarray exposed in the svec is populated only as a side-effect of the fixup walk and on every package image examined contained zeroTypeMapEntryobjects.Return both arrays alongside
internal_methodsin a 7-element svec so the information is once again accessible.