DILocation: Support 32-bit column number#52
Open
topolarity wants to merge 1 commit into
Open
Conversation
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
topolarity
force-pushed
the
ct/dwarf-32bit-col
branch
from
3bf743b to
aa56f7c
Compare
Member
Author
Member
Author
|
@maleadt Gabriel mentioned that GPU backends sometimes care about the serialized LLVM IR I don't think this should cause any major incompatibilities, although there's a good chance the >16-bit column numbers could cause older LLVM's without the patch to reject the IR? I assume the downgrader might need an upgrade |
Member
|
Would be good to open upstream |
Member
Author
Already open (llvm#201269) but it's an awkward pitch so far, esp. given upcoming changes If you have thoughts, let me know @vchuravy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by JuliaLang/julia#61699 / JuliaLang/julia#53925
This allows Julia to recover DebugInfo indices from the DWARF column for functions with > 65k IR statements.
Functions of that length are not terribly uncommon, so we likely want to carry this patch even though upstream probably won't be very interested in it.