WIP: Array function - #3
Open
elisno wants to merge 3 commits into
Open
Conversation
Collaborator
|
Thanks for the comments and PR. It could be that writing methods for |
jlapeyre
force-pushed
the
master
branch
2 times, most recently
from
January 26, 2020 14:16
c95f98b to
5e6f821
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(I'm quite new to the whole package development process, so any feedback would be appreciated.)
I've modified existing methods in
weeks.jlto evaluate the ILT of vector valued functions. This avoids repeated function evaluations when sampling the function (before the FFT).It might be a good idea to make a seperate method, since scalar functions now output a vector of
length = 1.Currently, calling
w.(t::AbstractArray)isn't optimized and it outputs a vector of incorrectly nested vectors. Apparently, the length of the vector-function has to be an integer power of 2, otherwise the ordering of the output will be off (probably due to the call tofftshift).I've added a test case which is similar to the complex one. It only evaluates
w(t), for a single value oft.I haven't tried it yet, but this method could be generalized any array valued functions, so long that the function samples
FFare stored along the first dimension (plans for the FFT would then be always be along the "columns").