Add libjulia 1.5.4#2898
Closed
devmotion wants to merge 3 commits into
Closed
Conversation
Member
|
For the failure on macOS see However I have no clue how this is going to work in terms of compatibility, @staticfloat do you have more insights? |
Member
|
What are the compatibility concerns you're thinking of? |
Member
|
libjulia 1.5.4 is incompatible with previous 1.5.x versions, because of changes to an internal data structure: TuringLang/Turing.jl#1568 (comment) |
Member
|
Seems that users can just bound their compat entries accordingly, if they are sensitive to the layout. That is really unfortunate, but I can see how it slipped through. |
Merged
Contributor
|
Closing this in favor of the rebased version at #3418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to solve #2792 (comment). I just updated the version number and the checksum - maybe this should be done differently or something is missing?