Skip to content

Add support for package preferences - #90

Merged
cjdoris merged 5 commits into
JuliaPy:mainfrom
MilesCranmerBot:preferences
Aug 7, 2026
Merged

Add support for package preferences#90
cjdoris merged 5 commits into
JuliaPy:mainfrom
MilesCranmerBot:preferences

Conversation

@MilesCranmerBot

Copy link
Copy Markdown
Contributor

Fixes #89

Package entries in juliapkg.json may now include an optional "preferences" object, which is written to the [preferences.<pkg> table of the generated Project.toml (read natively by Julia's Pkg, as used by Preferences.jl). Preferences from multiple juliapkg.json files are merged by key; conflicting values for the same key raise an error.

{"packages": {"SymbolicRegression": {"uuid": "8254be44-1295-4e6a-a16d-46603ac705cb", "version": "1", "preferences": {"precompile_float64": false}}}}

MilesCranmerBot and others added 2 commits July 26, 2026 17:42
Package entries in juliapkg.json may now include an optional
"preferences" object, which is written to the [preferences.<pkg>]
table of the generated Project.toml (read natively by Julia's Pkg).

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
@cjdoris

cjdoris commented Aug 1, 2026

Copy link
Copy Markdown
Member

I like this! There's quite a lot of new text in the readme about this (not in keeping with the rest of the docs). I suggest removing it all and instead please add a preferences=None arg to the add function, and document that in the readme.

Also META_VERSION needs to be bumped.

@MilesCranmer

Copy link
Copy Markdown
Contributor

@MilesCranmerBot could you please address the above?

Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
@MilesCranmerBot

Copy link
Copy Markdown
Contributor Author

Done in 6db238c:

  • Trimmed the README back to one line under the juliapkg.json section and documented preferences on the add() signature instead.
  • add() now takes an explicit preferences=None arg.
  • Bumped META_VERSION 6 → 7.

Tests: 123 passed locally (pre-existing test_editable_setuptools env failure is unrelated).

@cjdoris
cjdoris merged commit 030a380 into JuliaPy:main Aug 7, 2026
6 checks passed
@cjdoris

cjdoris commented Aug 7, 2026

Copy link
Copy Markdown
Member

Thanks!

@cjdoris

cjdoris commented Aug 7, 2026

Copy link
Copy Markdown
Member

Released in v0.1.25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preferences.jl support

3 participants