Allow resolve to use Julia arguments - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
julia_argsargument tojuliapkg.resolve()run_julia()helper torun_script()and forward subprocess keyword argumentsMotivation
Downstream packages such as JuliaCall may start Julia with cache-affecting options such as
--check-bounds=yes. They can now pass those options into JuliaPkg so that parallel AOT precompilation uses compatible settings, without JuliaPkg needing to understand downstream configuration variables.This provides the JuliaPkg side of the proposed solution for #92.
Validation
uv run pytest -q— 125 passed, 5 skippeduv run pre-commit run --all-files— passedgit diff --check— passed