Skip to content

Update breakage: use organization-wide workflow#380

Merged
MaxenceGollier merged 3 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
May 6, 2026
Merged

Update breakage: use organization-wide workflow#380
MaxenceGollier merged 3 commits into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier
Copy link
Copy Markdown
Collaborator

Copilot AI review requested due to automatic review settings April 27, 2026 13:44
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the repository’s “Breakage” CI and PR-commenting logic to organization-wide reusable GitHub Actions workflows (per JuliaSmoothOptimizers/.github#18), removing the repo-local breakage implementation.

Changes:

  • Replace the repo’s custom Breakage workflow with a reusable workflow call.
  • Add a separate CommentBreakage workflow that runs on completion of the Breakage workflow and delegates to the org reusable workflow.
  • Remove the now-unused .breakage Julia helper script and its Project.toml.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/Breakage.yml Replaced the previous multi-job implementation with a call to the org-wide reusable Breakage workflow.
.github/workflows/CommentBreakage.yml New workflow to delegate PR commenting to the org-wide reusable CommentBreakage workflow after Breakage completes.
.breakage/get_jso_users.jl Removed unused helper script (logic moved to org workflow).
.breakage/Project.toml Removed unused breakage workflow dependencies (logic moved to org workflow).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/Breakage.yml Outdated
Comment thread .github/workflows/Breakage.yml
Comment thread .github/workflows/CommentBreakage.yml
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.32%. Comparing base (fc3ab2f) to head (22b05a0).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #380       +/-   ##
===========================================
- Coverage   92.23%   78.32%   -13.92%     
===========================================
  Files          13       13               
  Lines        1597     1836      +239     
===========================================
- Hits         1473     1438       -35     
- Misses        124      398      +274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaxenceGollier MaxenceGollier merged commit e8fd631 into JuliaSmoothOptimizers:main May 6, 2026
32 of 33 checks passed
@MaxenceGollier MaxenceGollier deleted the update-breakage branch May 6, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants