Skip to content

refactor!: unify CDFDataset views and multi-source datasets#46

Merged
Beforerr merged 1 commit into
mainfrom
push-mosnmumyyztk
May 12, 2026
Merged

refactor!: unify CDFDataset views and multi-source datasets#46
Beforerr merged 1 commit into
mainfrom
push-mosnmumyyztk

Conversation

@Beforerr
Copy link
Copy Markdown
Member

No description provided.

@Beforerr Beforerr force-pushed the push-mosnmumyyztk branch from 43705d9 to db33bec Compare May 12, 2026 04:28
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Benchmark Results (Julia v1)

Time benchmarks
main 760ead0... main / 760ead0...
clip/dataset-epoch 15 ± 0.9 μs 14.8 ± 0.83 μs 1.01 ± 0.084
clip/dataset-variable 25.9 ± 3.7 μs 25.9 ± 1 μs 1 ± 0.15
clip/variable 16.6 ± 11 μs 16.4 ± 0.89 μs 1.01 ± 0.69
concat/dataset/epoch 7.96 ± 0.24 μs 8.15 ± 0.31 μs 0.978 ± 0.048
concat/dataset/variable 8.34 ± 0.3 μs 8.32 ± 0.31 μs 1 ± 0.052
concat/variable/array 4.19 ± 3.8 μs 3.88 ± 3.7 μs 1.08 ± 1.4
concat/variable/construct 9.19 ± 0.4 μs 9.25 ± 0.37 μs 0.994 ± 0.059
dimarray/clip 0.0422 ± 0.0015 ms 0.0432 ± 0.0014 ms 0.978 ± 0.047
dimarray/concat 21.7 ± 1.5 μs 21.5 ± 1.1 μs 1.01 ± 0.086
dimarray/single 8.62 ± 0.44 μs 8.61 ± 0.42 μs 1 ± 0.071
metadata/dataset 30 ± 0 ns 30 ± 0 ns 1 ± 0
metadata/dim 9.23 ± 0.32 μs 9.58 ± 0.37 μs 0.963 ± 0.05
variable/disk/broadcast-realized 6.45 ± 0.59 μs 6.4 ± 0.48 μs 1.01 ± 0.12
variable/disk/maximum 3.26 ± 0.5 μs 3.11 ± 0.4 μs 1.05 ± 0.21
variable/disk/sum 2.99 ± 0.48 μs 2.9 ± 0.41 μs 1.03 ± 0.22
variable/materialize/elfin-flux 2.56 ± 0.48 μs 2.58 ± 0.43 μs 0.992 ± 0.25
variable/materialize/omni-v 0.411 ± 0.09 μs 0.411 ± 0.1 μs 1 ± 0.33
variable/materialized/broadcast 3.83 ± 0.51 μs 3.8 ± 0.36 μs 1.01 ± 0.17
variable/materialized/maximum 0.611 ± 0.01 μs 0.591 ± 0.001 μs 1.03 ± 0.017
variable/materialized/sum 0.381 ± 0.01 μs 0.361 ± 0.001 μs 1.06 ± 0.028
time_to_load 0.194 ± 0.002 s 0.193 ± 0.0047 s 1 ± 0.026
Memory benchmarks
main 760ead0... main / 760ead0...
clip/dataset-epoch 0.118 k allocs: 0.0397 MB 0.119 k allocs: 0.0399 MB 0.995
clip/dataset-variable 0.219 k allocs: 0.0453 MB 0.219 k allocs: 0.0453 MB 1
clip/variable 0.124 k allocs: 0.04 MB 0.124 k allocs: 0.04 MB 1
concat/dataset/epoch 0.094 k allocs: 5.41 kB 0.094 k allocs: 5.41 kB 1
concat/dataset/variable 0.094 k allocs: 5.41 kB 0.094 k allocs: 5.41 kB 1
concat/variable/array 17 allocs: 12.1 kB 17 allocs: 12.1 kB 1
concat/variable/construct 0.076 k allocs: 6.8 kB 0.076 k allocs: 6.8 kB 1
dimarray/clip 0.368 k allocs: 0.0553 MB 0.368 k allocs: 0.0553 MB 1
dimarray/concat 0.151 k allocs: 0.0425 MB 0.151 k allocs: 0.0425 MB 1
dimarray/single 0.046 k allocs: 14.4 kB 0.046 k allocs: 14.4 kB 1
metadata/dataset 0 allocs: 0 B 0 allocs: 0 B
metadata/dim 0.096 k allocs: 5.47 kB 0.096 k allocs: 5.47 kB 1
variable/disk/broadcast-realized 24 allocs: 0.0555 MB 24 allocs: 0.0555 MB 1
variable/disk/maximum 5 allocs: 27.7 kB 5 allocs: 27.7 kB 1
variable/disk/sum 5 allocs: 27.7 kB 5 allocs: 27.7 kB 1
variable/materialize/elfin-flux 5 allocs: 27.7 kB 5 allocs: 27.7 kB 1
variable/materialize/omni-v 5 allocs: 3.13 kB 5 allocs: 3.13 kB 1
variable/materialized/broadcast 3 allocs: 27.6 kB 3 allocs: 27.6 kB 1
variable/materialized/maximum 0 allocs: 0 B 0 allocs: 0 B
variable/materialized/sum 0 allocs: 0 B 0 allocs: 0 B
time_to_load 0.145 k allocs: 11 kB 0.145 k allocs: 11 kB 1

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/dataset.jl 86.66% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Beforerr Beforerr force-pushed the push-mosnmumyyztk branch from db33bec to 760ead0 Compare May 12, 2026 04:40
@Beforerr Beforerr merged commit 3827372 into main May 12, 2026
6 checks passed
@Beforerr Beforerr deleted the push-mosnmumyyztk branch May 12, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant