Add Censored distribution#1470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1470 +/- ##
==========================================
+ Coverage 84.26% 84.80% +0.54%
==========================================
Files 124 126 +2
Lines 7511 7778 +267
==========================================
+ Hits 6329 6596 +267
Misses 1182 1182
Continue to review full report at Codecov.
|
devmotion
left a comment
There was a problem hiding this comment.
Thanks, I left some initial comments 🙂
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
|
We could add the patch version increment for a release too. |
devmotion
left a comment
There was a problem hiding this comment.
Did you build the documentation locally and checked that it looks fine?
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Yes, all looks good. All changes have been incorporated and comments resolved, except for #1470 (comment). With recent changes, I replaced some special-casing in the expectations with a utility function |
|
This should be updated to use the new truncation syntax before merging. |
Co-authored-by: Moritz Schauer <moritzschauer@web.de>
|
Okay, this should be up-to-date with master again. |
|
@devmotion is anything else needed before merging this? |
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
|
@devmotion okay then, should be good to merge! |
This PR fixes #1468 for constructing a right-, left-, or interval-censored form of a distribution.