Improve Rician distribution#2039
Open
devmotion wants to merge 2 commits into
Open
Conversation
devmotion
commented
Mar 3, 2026
| ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4" | ||
| DensityInterface = "b429d917-457f-4dbc-8f4c-0cc954292b1d" | ||
| FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b" | ||
| HypergeometricFunctions = "34004b35-14d8-5ef3-9330-4cdb6864b03a" |
Member
Author
There was a problem hiding this comment.
Already an indirect dependency via StatsFuns
devmotion
commented
Mar 3, 2026
Comment on lines
+29
to
+30
| @test all(splat(isapprox), zip(ccdf.(d1, xs), @. exp(-xs^2/200))) | ||
| @test all(splat(isapprox), zip(logccdf.(d1, xs), @. -xs^2/200)) |
Member
Author
There was a problem hiding this comment.
The fallbacks are too inaccurate, without dedicated overloads for ccdf and logccdf these tests fail.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2039 +/- ##
==========================================
+ Coverage 86.74% 86.76% +0.02%
==========================================
Files 149 149
Lines 8882 8896 +14
==========================================
+ Hits 7705 7719 +14
Misses 1177 1177 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2035