Fix fit_mle dispatch for instantiated/concrete MvNormal aliases#2078
Fix fit_mle dispatch for instantiated/concrete MvNormal aliases#2078rsenne wants to merge 1 commit into
fit_mle dispatch for instantiated/concrete MvNormal aliases#2078Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2078 +/- ##
=======================================
Coverage 86.74% 86.74%
=======================================
Files 149 149
Lines 8883 8883
=======================================
Hits 7706 7706
Misses 1177 1177 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I'm not even sure this should be considered a bug and be "fixed". The loose To summarize, I think the better as more faithful approach is to not support |
|
I agree on the long-term design: But I'd like to separate that design question from what I think is the real issue: compatibility. Generic code that refits distributions with So I think the best middle ground is to reinstate the previous behavior but emit a deprecation warning, which addresses your concern while not breaking existing code in a patch release. That restores what worked, signals the intended direction, and gives downstream users a clear message instead of a cryptic error. |
|
Alternatively --I took a crack at making the fitting path type-generic. Fitting now works for any real Kept the As a note I also did something similar for the univariate case. |
Fixes #2074.
This widens the 7
fit_mlesignatures toD::Type{<:...}so the aliases areaccepted in any form (bare, instantiated, or concrete member), restoring the
pre-#2073 behavior. Added tests cover the instantiated and concrete-type paths,
which the existing bare-alias tests didn't exercise.