Adds optional progress bar#144
Merged
Merged
Conversation
Collaborator
Author
|
Tests are passing after fixing some silly mistakes on my end. But there are issues with codecov--presumably caused by changing repo ownership? |
gdalle
approved these changes
May 10, 2026
| fit!(hmm, fb_storage, obs_seq, control_seq; seq_ends) | ||
| if baum_welch_has_converged(logL_evolution; atol, loglikelihood_increasing) | ||
| break | ||
| if progress |
Member
There was a problem hiding this comment.
Ideally we'd want something like JuliaLogging/ProgressLogging.jl#33 to avoid introducing progress logging overhead when the user deactivates it. As of right now, a bit of code duplication doesn't hurt
| using ProgressLogging: ProgressLevel | ||
| using Random: Xoshiro | ||
| using Test | ||
| using Test: TestLogger |
Member
There was a problem hiding this comment.
Nice, didn't know about that one!
Member
I added you as a contributor so that next time you may submit PRs from your clone instead of a fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #131.
You were right that ProgressLogging was the right move. This PR only adds it as an optional kwarg on Baum-Welch so a user can decide if they need it or not--by default
progress::Bool=false. I figure that's the least intrusive addition.Let me know what you think!