Hotfix for #177#118
Conversation
fix for #/117
|
This PR only raises the lower bound for FileIO, so I don't think it fixes the problem? Depending on the Pkg resolver, users might not even benefit from an upper bound - the new version of RDatasets might not be installed automatically since it would involve downgrading some other packages (such as FileIO). |
|
Wait, doesn't 1.5 mean only 1.5.x is allowed? |
|
No, it means [1.5.0, 2.0.0): https://julialang.github.io/Pkg.jl/v1/compatibility/#Caret-specifiers |
|
Hah, yeah I just checked; it's been too long since I've touched |
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 84.00% 81.81% -2.19%
==========================================
Files 4 4
Lines 25 22 -3
==========================================
- Hits 21 18 -3
Misses 4 4
Continue to review full report at Codecov.
|
|
Could we check (or does anyone know) if Pkg would install such a hotfix when running |
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
|
I close this PR since the issue is fixed upstream. Maybe #119 could still be useful but that's a separate issue. |
Fix for #117 thanks to @devmotion
Seems like it would be a good idea to get this in ASAP and then change back when FileIO.jl has been fixed.