working#695
Merged
Merged
Conversation
|
@EmeditWeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #567
Add Secure Whitelist Module for Approved Strategy Contract IDs
Overview
This PR implements a dedicated, reusable
SecureWhitelistmodule to manage approved strategy contract IDs for the YieldVault protocol on Stellar Soroban.Changes
Code Implementation
contracts/vault/src/whitelist.rs(220 lines)SecureWhiteliststruct with 4 core functionsadd_strategy()- Add strategy to whitelist (admin-only)remove_strategy()- Remove from whitelist (admin-only)is_strategy_whitelisted()- Check whitelist status (read-only)set_whitelist_status()- Toggle approval (admin-only)Integration
contracts/vault/src/lib.rsset_strategy()to validate whitelistwhitelist_strategy()to use moduleis_strategy_whitelisted()to use moduleTesting
contracts/vault/src/test.rsKey Features
✅ Admin-Only Authorization - Only vault admin can modify whitelist
✅ Secure Storage - Follows Soroban storage best practices
✅ State Persistence - Whitelist survives vault operations
✅ Backward Compatible - No breaking changes to existing code
✅ Production-Ready - Comprehensive error handling and documentation
Testing
All tests pass: